bug with notification, felamimail and redirect

classic Classic list List threaded Threaded
8 messages Options
zorg zorg
Reply | Threaded
Open this post in threaded view
|

bug with notification, felamimail and redirect

HI
If we use EGW1.6 with notification and the preference set for external
mail client link

If I open message alerting from new event calendar the url is like that
http://domain.com/egroupware/redirect.php?go=http://domain.com/egroupware/index.php?menuaction=calendar.calendar_uiforms.edit&cal_id=4051&date=20090620&no_popup=1

the problem is that the redirect.php doesn't handle variable in redirect
correctly and they get lost

One solution is to modify the redirect php code like this


 if($_GET['go'])
        {
                $url= html_entity_decode(urldecode($_GET['go']));
                unset($_GET['go']);
                $url=$url."&".http_build_query($_GET);

                Header('Location: ' . html_entity_decode(urldecode($url)));
                exit;
        }



For me it's a serious bug

Hope it help

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
eGroupWare-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
Leithoff, Klaus Leithoff, Klaus
Reply | Threaded
Open this post in threaded view
|

Re: bug with notification, felamimail and redirect

Hi Zorg,
commited to trunk as Revision 27288
svn commit redirect.php -m"redirection via go, by rebuilding the query
string; suggested by zorg; seems to work without sideeffects in my
enviroment; please give feedback to the '[eGroupWare-developers] bug with
notification,felamimail and redirect' entry"

We will wait for feedback, before commiting it to 1.6.
Best regards
Leithoff, Klaus
 
----------------ursprüngliche Nachricht-----------------
Von: "zorg" [hidden email]
An: [hidden email]
Datum: Thu, 18 Jun 2009 20:44:39 +0200
-------------------------------------------------
 
 

> HI
> If we use EGW1.6 with notification and the preference set for external
> mail client link
>
> If I open message alerting from new event calendar the url is like that
>
> http://domain.com/egroupware/redirect.php?go=http://domain.com/egrou
> pware/index.php?menuaction=calendar.calendar_uiforms.edit&cal_id=405
> 1&date=20090620&no_popup=1
>
> the problem is that the redirect.php doesn't handle variable in redirect
> correctly and they get lost
>
> One solution is to modify the redirect php code like this
>
>
> if($_GET['go'])
> {
> $url= html_entity_decode(urldecode($_GET['go']));
> unset($_GET['go']);
> $url=$url."&".http_build_query($_GET);
>
> Header('Location: ' . html_entity_decode(urldecode($url)));
> exit;
> }
>
>
>
> For me it's a serious bug
>
> Hope it help
>
>
> --------------------------------------------------------------------
> ----------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables unlimited
> royalty-free distribution of the report engine for externally facing
> server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> eGroupWare-developers mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/egroupware-developers
>

--
Stylite GmbH
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden

fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de

Handelsregister Kaiserslautern HRB 30575
Geschäftsführer: Andre Keller, Gudrun Müller, Nigel Vickers, Ralf Becker



------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
eGroupWare-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
Nathan Gray-2 Nathan Gray-2
Reply | Threaded
Open this post in threaded view
|

Re: bug with notification, felamimail and redirect


On 19-Jun-09, at 2:34 AM, Klaus Leithoff wrote:

> Hi Zorg,
> commited to trunk as Revision 27288
> svn commit redirect.php -m"redirection via go, by rebuilding the query
> string; suggested by zorg; seems to work without sideeffects in my
> enviroment; please give feedback to the '[eGroupWare-developers] bug  
> with
> notification,felamimail and redirect' entry"
>
> We will wait for feedback, before commiting it to 1.6.

We're getting random redirects and links going to random places.
Tough to narrow down, because it doesn't seem repeatable, but I  
haven't had any complaints since I reverted.

Nathan Gray
nathan at goarctic dot com


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
eGroupWare-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
Leithoff, Klaus Leithoff, Klaus
Reply | Threaded
Open this post in threaded view
|

Re: bug with notification, felamimail and redirect

Hmmm,
strange, I have that with my trunk and with the production site of the
company I work for, now for quite a while,
and get none of the reported stuff
Klausi
 
----------------ursprüngliche Nachricht-----------------
Von: "Nathan Gray" [hidden email]
An: "development of eGroupWare,for active developers"
[hidden email]
Datum: Fri, 4 Sep 2009 08:22:06 -0600
-------------------------------------------------
 
 

>
> On 19-Jun-09, at 2:34 AM, Klaus Leithoff wrote:
>
>> Hi Zorg,
>> commited to trunk as Revision 27288
>> svn commit redirect.php -m"redirection via go, by rebuilding the query
>> string; suggested by zorg; seems to work without sideeffects in my
>> enviroment; please give feedback to the '[eGroupWare-developers] bug
>> with
>> notification,felamimail and redirect' entry"
>>
>> We will wait for feedback, before commiting it to 1.6.
>
> We're getting random redirects and links going to random places.
> Tough to narrow down, because it doesn't seem repeatable, but I
> haven't had any complaints since I reverted.
>
> Nathan Gray
> nathan at goarctic dot com
>
>
>
> --------------------------------------------------------------------
> ----------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008
30-Day
> trial. Simplify your report design, integration and deployment - and focus
on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________
> eGroupWare-developers mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/egroupware-developers
>

--
Stylite GmbH
[ open style of IT ]
Morschheimer Strasse 15
67292 Kirchheimbolanden

fon 06352 . 70629-0
fax 06352 . 70629-30
www.stylite.de

Geschäftsführer: Andre Keller, Gudrun Müller, Nigel Vickers, Ralf Becker
Handelsregister Kaiserslautern HRB 30575
USt-ID: DE214280951
SteuerNr. 44/667/1114/3



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
eGroupWare-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
Nathan Gray-2 Nathan Gray-2
Reply | Threaded
Open this post in threaded view
|

Re: bug with notification, felamimail and redirect


On 7-Sep-09, at 3:29 AM, Klaus Leithoff wrote:

> Hmmm,
> strange, I have that with my trunk and with the production site of the
> company I work for, now for quite a while,
> and get none of the reported stuff

Very strange.  I'll try it with our test site again this week, and see  
if I can figure out what the issue is.

Nathan Gray
nathan at goarctic dot com


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
eGroupWare-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
Nathan Gray-2 Nathan Gray-2
Reply | Threaded
Open this post in threaded view
|

Re: bug with notification, felamimail and redirect


On 8-Sep-09, at 8:02 AM, Nathan Gray wrote:

>
> On 7-Sep-09, at 3:29 AM, Klaus Leithoff wrote:
>
>> Hmmm,
>> strange, I have that with my trunk and with the production site of  
>> the
>> company I work for, now for quite a while,
>> and get none of the reported stuff
>
> Very strange.  I'll try it with our test site again this week, and see
> if I can figure out what the issue is.

Put it in production, no complaints.
Must have been one of those things...

Nathan Gray
nathan at goarctic dot com


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
eGroupWare-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
Nathan Gray-2 Nathan Gray-2
Reply | Threaded
Open this post in threaded view
|

Re: bug with notification, felamimail and redirect


On 6-Oct-09, at 10:23 AM, Nathan Gray wrote:

> Put it in production, no complaints.
> Must have been one of those things...

Spoke too soon.  Don't know if it's related, but it just happened to  
me as I changed a filter in a nextmatch (pERP Sales Order list).
It seems to be related to something getting cleared.  I was redirected  
to a 'No permission to this app' exception for a different app (I have  
permission) and my template preference was changed from idots to  
jerryr.  This preference change persisted across logout.

Very strange, and of course, not repeatable.
I do not have the knowledge of that section of eGroupWare needed to  
dig into this.

Nathan Gray
nathan at goarctic dot com


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
eGroupWare-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/egroupware-developers
Ralf Becker Ralf Becker
Reply | Threaded
Open this post in threaded view
|

Re: bug with notification, felamimail and redirect

Hmm,

preferences are read by preferences class in API, which get's
instanciated as $GLOBALS['egw']->preferences and stored in the session,
unless someone calls egw::invalidate_session_cache();
The effective prefs itself are in
$GLOBALS['egw_info']['user']['preferences'][$app] ($app = 'common', for
common / app-independent prefs).

Good luck :-)

Ralf

Nathan Gray schrieb:

> On 6-Oct-09, at 10:23 AM, Nathan Gray wrote:
>
>> Put it in production, no complaints.
>> Must have been one of those things...
>
> Spoke too soon.  Don't know if it's related, but it just happened to  
> me as I changed a filter in a nextmatch (pERP Sales Order list).
> It seems to be related to something getting cleared.  I was redirected  
> to a 'No permission to this app' exception for a different app (I have  
> permission) and my template preference was changed from idots to  
> jerryr.  This preference change persisted across logout.
>
> Very strange, and of course, not repeatable.
> I do not have the knowledge of that section of eGroupWare needed to  
> dig into this.
>
> Nathan Gray
> nathan at goarctic dot com
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry® Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9-12, 2009. Register now!
> http://p.sf.net/sfu/devconf
> _______________________________________________
> eGroupWare-developers mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/egroupware-developers

--
Ralf Becker
Director Software Development

Stylite GmbH
[open style of IT]

Morschheimer Strasse 15
67292 Kirchheimbolanden

fon  +49 (0) 6352 70629-0
fax  +49 (0) 6352 70629-30
mailto: [hidden email]

www.stylite.de
www.egroupware.org
________________________________________________

Geschäftsführer Andre Keller,
        Gudrun Müller, Ralf Becker
Registergericht Kaiserslautern HRB 30575
Umsatzsteuer-Id / VAT-Id: DE214280951

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
eGroupWare-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/egroupware-developers